Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add caption renderer #675

Open
wants to merge 8 commits into
base: feature/rooms-captions
Choose a base branch
from
Open

Add caption renderer #675

wants to merge 8 commits into from

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented May 3, 2022 •
edited
Loading

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds a CaptionsRenderer to the video app. This can be enabled by clicking on the Show Captions button in the More menu:

image

With this enabled, captions will be rendered on the screen.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza requested a review from olipyskoty May 3, 2022 22:17
olipyskoty
olipyskoty suggested changes May 4, 2022
View reviewed changes
Copy link
Contributor

@olipyskoty olipyskoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good! Just a comment about changing the useTracks() hook name to something like useParticipantTracks() like we discussed.

@timmydoza timmydoza requested a review from olipyskoty May 6, 2022 22:59
@Geczy
Copy link

Geczy commented Jul 9, 2022

can this get merged?

@lovedota
Copy link

I tried this code, but it doesn't work ? Do we need a new api key for transcription ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olipyskoty olipyskoty olipyskoty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timmydoza @Geczy @lovedota @olipyskoty